Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruff] Run make checkstyle on the main branch #550

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hongpeng-guo
Copy link
Collaborator

@hongpeng-guo hongpeng-guo commented Jan 30, 2025

Summary

This PR simply runs make checkstyle on the main branch. All the changes are auto generated by ruff.
The main goal doing this is to avoid leaving these re-formatting into following PRs when running make checkstyle. These reformatting will be irrelevant to any following PRs.

Side note: Not sure why these changes are not captured by the checkstyle unit tests.

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

Signed-off-by: Hongpeng Guo <[email protected]>
@Tcc0403
Copy link
Collaborator

Tcc0403 commented Jan 30, 2025

Could it be an environment issue? There is no changes for me on when I runmake checkstyle on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants