bugfix(edit-text): Ensure that the Samsung keyboard cannot remove mentions with it's grammatical corrections #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions with it's grammatical corrections
…tions with it's grammatical corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been experiencing issues related to persisting mentions when the user is running a recent Samsung device. It looks to me like this issue had been attempted to be fixed with the use of the
PlaceholderSpan, however in my case I'm seeing that even these are removed from the text.My fix involves persisting the placeholder in the
MentionsEditTextclass, rather than holding onto them as part of the spannable string. This seems to have fixed the issue for now.I'm not sure that this project is actively maintained, but would be grateful if anyone can offer advice on this and whether or not my approach is appropriate.