Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move id converter to router for put and ttl update handler logic #2983

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SophieGuo410
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 64.84375% with 45 lines in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (52ba813) to head (dc43984).
Report is 166 commits behind head on master.

Files with missing lines Patch % Lines
...ava/com/github/ambry/router/NonBlockingRouter.java 33.33% 29 Missing and 3 partials ⚠️
...n/java/com/github/ambry/router/InMemoryRouter.java 69.76% 10 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2983      +/-   ##
============================================
+ Coverage     64.24%   70.09%   +5.84%     
- Complexity    10398    12164    +1766     
============================================
  Files           840      884      +44     
  Lines         71755    74856    +3101     
  Branches       8611     8973     +362     
============================================
+ Hits          46099    52468    +6369     
+ Misses        23004    19657    -3347     
- Partials       2652     2731      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SophieGuo410 SophieGuo410 force-pushed the Branch_id_converter_continue_phase1 branch 3 times, most recently from 208546b to 2c94dcb Compare January 17, 2025 00:28
@SophieGuo410 SophieGuo410 force-pushed the Branch_id_converter_continue_phase1 branch from 2c94dcb to c165b21 Compare January 17, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants