[FileCopy based bootstrap] GetMetadata Api #2991
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevenAhluwalia
commented
Jan 22, 2025
| @@ -110,7 +110,7 @@ public static class LocalChannelRequest implements NetworkRequest { | |||
| private long startTimeInMs; | |||
| private int processorId; | |||
|
|
|||
| LocalChannelRequest(RequestInfo requestInfo, int processorId) { | |||
| public LocalChannelRequest(RequestInfo requestInfo, int processorId) { | |||
There was a problem hiding this comment.
Revert this diff
| logInfos.size(), logInfos, ServerErrorCode.No_Error); | ||
|
|
||
| // TODO: Add metrics for this operation | ||
| Histogram dummyHistogram = new Histogram(new Reservoir() { |
There was a problem hiding this comment.
Fix this histogram and add metrics for this api
| requestResponseChannel.sendResponse(response, request, serverNetworkResponseMetrics); | ||
| } | ||
|
|
||
| private List<LogInfo> convertStoreToProtocolLogInfo(List<com.github.ambry.store.LogInfo> logSegments) { |
There was a problem hiding this comment.
Figure out if there is a better place to keep this conversion util.
| @@ -484,6 +494,30 @@ public void startup() throws InstantiationException { | |||
| } | |||
| } | |||
|
|
|||
| private void testGetMetadataApi() { | |||
There was a problem hiding this comment.
Test code. To be reverted.
| @@ -229,7 +230,8 @@ public AmbryServerRequestsTest(boolean validateRequestOnStoreState, boolean enab | |||
|
|
|||
| @Parameterized.Parameters | |||
| public static List<Object[]> data() { | |||
| return Arrays.asList(new Object[][]{{false, false}, {true, false}, {false, true}, {true, true}}); | |||
| // return Arrays.asList(new Object[][]{{false, false}, {true, false}, {false, true}, {true, true}}); | |||
| return Arrays.asList(new Object[][]{{false, false}}); | |||
There was a problem hiding this comment.
Revert this.
| @@ -1645,6 +1647,17 @@ public void healthCheckTest() throws InterruptedException, StoreException, IOExc | |||
| setPropertyToAmbryRequests(currentProperties, "disk.manager.disk.healthcheck.enabled", "false"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void fileCopyGetMetaDataRequestTest() throws IOException, InterruptedException { | |||
| @@ -326,7 +328,8 @@ public void start() throws StoreException { | |||
| } | |||
| metrics.storeStartFailure.inc(); | |||
| String err = String.format("Error while starting store for dir %s due to %s", dataDir, e.getMessage()); | |||
| throw new StoreException(err, e, StoreErrorCodes.Initialization_Error); | |||
| // [Dw-remove] | |||
| // throw new StoreException(err, e, StoreErrorCodes.Initialization_Error); | |||
There was a problem hiding this comment.
Revert this.
| List<FileInfo> sealedLogsAndMetaDataFiles = getLogSegments(includeActiveLogSegment); | ||
| if (null != sealedLogsAndMetaDataFiles) { | ||
| for (FileInfo E : sealedLogsAndMetaDataFiles) { | ||
| logger.info("[Dw] LS file: {} size: {}", E.getFileName(), E.getFileSize()); |
There was a problem hiding this comment.
Fix logging statements. Remove Dw prefix.
| @@ -195,6 +196,9 @@ void start(boolean shouldRemoveUnexpectedDirs) throws InterruptedException { | |||
| Thread thread = Utils.newThread("store-startup-" + partitionAndStore.getKey(), () -> { | |||
| try { | |||
| partitionAndStore.getValue().start(); | |||
| // [Dw remove] | |||
| // logger.info("[Dw] PrintUtil for PartitionId: " + partitionAndStore.getKey().getId()); | |||
| // partitionAndStore.getValue().printAndReturnFiles(); | |||
There was a problem hiding this comment.
Revert this diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.