Generate partition scope DLO strategy and persist to DLO table #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumedhsakdeo
reviewed
Feb 4, 2025
...ark/src/main/java/com/linkedin/openhouse/jobs/spark/DataLayoutStrategyGeneratorSparkApp.java
Outdated
Show resolved
Hide resolved
sumedhsakdeo
requested changes
Feb 4, 2025
...t/src/main/java/com/linkedin/openhouse/datalayout/generator/DataLayoutStrategyGenerator.java
Show resolved
Hide resolved
libs/datalayout/src/main/java/com/linkedin/openhouse/datalayout/datasource/TableFileStats.java
Outdated
Show resolved
Hide resolved
| Row partition = row.getStruct(2); | ||
| if (partition != null) { | ||
| for (int i = 0; i < partition.size(); i++) { | ||
| partitionValues.add(Objects.toString(partition.get(i))); |
There was a problem hiding this comment.
What does the string representation look like?
There was a problem hiding this comment.
It looks like "2024-02-01, CA".
There was a problem hiding this comment.
It should have partCol1=partVal1, partCol2=partVal2, ... ?
...n/java/com/linkedin/openhouse/datalayout/generator/OpenHouseDataLayoutStrategyGenerator.java
Outdated
Show resolved
Hide resolved
|
|
||
| private Optional<DataLayoutStrategy> buildDataLayoutStrategy( | ||
| Dataset<Long> fileSizes, int partitionCount, String partitionValue) { |
There was a problem hiding this comment.
Is it partitionValue or partitionValues, if there are more than one partition column?
There was a problem hiding this comment.
partitionValue is the string representation of list of partitionValues.
...va/com/linkedin/openhouse/datalayout/generator/OpenHouseDataLayoutStrategyGeneratorTest.java
Show resolved
Hide resolved
jiang95-dev
force-pushed
the
lejiang/add-dlo-partition-table
branch
from
619844f to
9012af8
Compare
teamurko
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Thank you @jiang95-dev, overall looks great, having a few minor comments
...src/test/java/com/linkedin/openhouse/datalayout/persistence/StrategiesDaoTablePropsTest.java
Outdated
Show resolved
Hide resolved
| SparkSession spark, | ||
| String outputFqtn, | ||
| List<DataLayoutStrategy> strategies, | ||
| boolean isPartitionScope) { | ||
| if (outputFqtn != null && !strategies.isEmpty()) { | ||
| createTableIfNotExists(spark, outputFqtn); |
There was a problem hiding this comment.
create table schema will have partition_id
...n/java/com/linkedin/openhouse/datalayout/generator/OpenHouseDataLayoutStrategyGenerator.java
Outdated
Show resolved
Hide resolved
| try (SparkSession spark = getSparkSession()) { | ||
| spark.sql("USE openhouse"); | ||
| spark.sql( | ||
| String.format("CREATE TABLE %s (id INT, data STRING) PARTITIONED BY (id)", testTable)); |
There was a problem hiding this comment.
could you do 2 columns, +1 timestamp with day granularity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generate partition scope DLO strategy and persist to DLO table.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.