[da-vinci] Bug fix for peer discovery in DVC with multi-stores #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-nagarajan
reviewed
Feb 5, 2025
| * @return the store client | ||
| */ | ||
| AbstractAvroStoreClient getStoreClient(String storeName) { | ||
| if (!storeToClientMap.containsKey(storeName)) { |
There was a problem hiding this comment.
Since its using a concurrent map, is it better to use computeIfAbsent instead of containsKey and put?
There was a problem hiding this comment.
Good call! updated with computeIfAbsent.
sixpluszero
reviewed
Feb 5, 2025
clients/da-vinci-client/src/main/java/com/linkedin/davinci/blobtransfer/BlobTransferUtil.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[da-vinci] Bug fix for peer discovery in DVC with multi-stores
When testing blob transfer on DVC hosts with multiple stores, it was found that some stores encountered errors while finding peers. The error message is as follows:
2025/01/30 18:41:32.990 ERROR [DaVinciBlobFinder] [ForkJoinPool.commonPool-worker-58] [flip-war] [] Error finding DVC peers for blob transfer in store: FeedEngagementCounts4dByRootObjectUrn, version: 191, partition: 198 java.lang.IllegalArgumentException: argument "src" is null at com.fasterxml.jackson.databind.ObjectMapper._assertNotNull(ObjectMapper.java:5072) ~[com.fasterxml.jackson.core.jackson-databind-2.18.0.jar:2.18.0] at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3920) ~[com.fasterxml.jackson.core.jackson-databind-2.18.0.jar:2.18.0] at com.linkedin.venice.blobtransfer.DaVinciBlobFinder.lambda$discoverBlobPeers$0(DaVinciBlobFinder.java:45)The root cause was traced to the peerFinder using the clientConfig from the daVinciBackend during initialization. However, when daVinciBackend is initialized, it only occurs for the first store, and subsequent stores reuse the existing daVinciBackend (refer: AvroGenericDaVinciClient.java). As a result, only the clientConfig from the first store is passed to the peerFinder, causing the peerFinder to send requests to the first store's router to retrieve peer information.
This PR updates the logic to pass the clientConfig to the peerFinder and creates a separate store client for each store.
How was this PR tested?
integration test.
Does this PR introduce any user-facing changes?