Don’t give up workflow when task returns false anymore #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts an earlier change. Workflows are not given up anymore if a task would return false. This was not intuitive and could potentially hide an actual issue within the task. Given up workflows would also be persisted for quite some time, which shouldn't happen, given there was no error or failed task. In the end, this broke Pallets' contract of defining a workflows contract from the beginning and being able to follow execution through all of its tasks; short-circuiting would mean workflows could complete without executing all tasks. A similar behaviour can be achieved by setting a context key and adding check it on the subsequent task(s).