Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t give up workflow when task returns false anymore #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linkyndy
Copy link
Owner

This reverts an earlier change. Workflows are not given up anymore if a task would return false. This was not intuitive and could potentially hide an actual issue within the task. Given up workflows would also be persisted for quite some time, which shouldn't happen, given there was no error or failed task. In the end, this broke Pallets' contract of defining a workflows contract from the beginning and being able to follow execution through all of its tasks; short-circuiting would mean workflows could complete without executing all tasks. A similar behaviour can be achieved by setting a context key and adding check it on the subsequent task(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant