Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: update pyenv to use environment name #35

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jriddle-linode
Copy link
Contributor

📝 Description

What does this PR do and why is this change necessary?

Updates pyenv to point to local environment setup by devenv.

@jriddle-linode jriddle-linode added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Apr 25, 2024
@jriddle-linode jriddle-linode requested a review from a team as a code owner April 25, 2024 20:36
@jriddle-linode jriddle-linode requested review from lgarber-akamai and yec-akamai and removed request for a team April 25, 2024 20:36
Copy link
Collaborator

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing linter is unrelated to this change 👍

Copy link

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could we reformat /home/runner/work/ansible-specdoc/ansible-specdoc/ansible_specdoc/objects.py as part of this change? Just to fix the lint error.

@lgarber-akamai
Copy link
Collaborator

lgarber-akamai commented Apr 26, 2024

LGTM.

Could we reformat /home/runner/work/ansible-specdoc/ansible-specdoc/ansible_specdoc/objects.py as part of this change? Just to fix the lint error.

@yec-akamai Coincidentally I just put up a PR to address this, a review would definitely be appreciated! #36

@jriddle-linode jriddle-linode merged commit f05835e into linode:main Apr 29, 2024
1 of 2 checks passed
@jriddle-linode jriddle-linode deleted the new/pyenv branch April 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo-ci-improvement for improvements in the repository or CI workflow in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants