Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of test errors; update dependencies; improve test invocation #147

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

okokes-akamai
Copy link
Contributor

I started off just improving our newly working e2e tests, but ended up doing a few extra maint things I found useful:

  • updated Expect/Eventually to make BeTrue failures more readable
  • rewrote the WaitForReady retry loop to avoid the appscode/go dependency (redundant + long abandoned) -> removed the dependency as a result
  • bumped ginkgo (and gomega) for better test progress reporting
  • increased verbosity of tests, removed the deprecated --progress flag
  • added parallelism to tests (4m -> 90s in terms of runtime)
  • did not test against v0.6.0, only against a random LKE cluster (v0.5.2 I believe), so I had to --skip=Raw for it to work

Note: I'm not a huge fan of func (...) IsPodReady(...) error as the naming suggests a bool return value. I did try that at first, but found the bool to be redundant, since I could easily encode the message in an error, but didn't find a more suitable name for the method.

@luthermonson
Copy link
Contributor

Ran 5 of 5 Specs in 80.387 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped

@luthermonson luthermonson merged commit 8ba69d4 into main Dec 15, 2023
3 checks passed
@luthermonson luthermonson deleted the betrue branch December 15, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants