Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script to look at just the id #179

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix script to look at just the id #179

merged 2 commits into from
Jun 25, 2024

Conversation

tchinmai7
Copy link
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?
    The get-linode-id script can produce a mangled linode-id when there's a tag with a id in there. For example with a metadata response like this
backups.enabled: true
backups.status: pending
host_uuid: 2d56ceffafec9f76be86e1d2d1dd37ec2204b28f
id: 60586846
label: jkvbpzyzqaa9pj8ix-master-0
region: us-ord
specs.disk: 163840
specs.gpus: 0
specs.memory: 8192
specs.transfer: 5000
specs.vcpus: 4
tags: cluster:kpp-api-single
tags: clusterUid:jkvbpzyzqaa9pj8ix
tags: prov-from:mgmt-cluster.akamai-kpp.com
type: g6-standard-4

the script ends up with

60586846clusterUid:jkvbpzyzqaa9pj8i

This fixes it by explictly asking for json and looking only at the "id" param.

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@tchinmai7 tchinmai7 requested review from a team as code owners June 24, 2024 21:26
@tchinmai7 tchinmai7 merged commit 3b2b193 into linode:main Jun 25, 2024
4 checks passed
@tchinmai7 tchinmai7 deleted the main branch June 25, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants