Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] device name when performing luks close #260

Merged
merged 3 commits into from
Sep 25, 2024
Merged

[fix] device name when performing luks close #260

merged 3 commits into from
Sep 25, 2024

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Sep 24, 2024

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@amold1 amold1 requested review from a team as code owners September 24, 2024 12:46
@amold1 amold1 removed request for a team September 24, 2024 12:46
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.02%. Comparing base (793c309) to head (6ad76d2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/luks.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   53.08%   53.02%   -0.07%     
==========================================
  Files          22       22              
  Lines        1588     1588              
==========================================
- Hits          843      842       -1     
- Misses        700      701       +1     
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once you revert the temp e2e test changes, I'll approve!

@amold1 amold1 self-assigned this Sep 25, 2024
@amold1 amold1 merged commit 3a76060 into main Sep 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants