Replace get_client with test_linode_client
#346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
jriddle-linode,
ykim-1,
a team,
amisiorek-akamai,
vshanthe and
lgarber-akamai
and removed request for
a team
jriddle-linode
approved these changes
Nov 7, 2023
ykim-1
approved these changes
Nov 7, 2023
zliang-akamai
added a commit
that referenced
this pull request
Nov 8, 2023
* Add support for VPCs * Drop debug statement * Clean up * Revert * oops * Add docs * Add reorder test * Add reorder test * make format * oops * Fix VPCSubnet docs * Address feedback * Use `asdict` to convert dataclass objects to dicts (#324) * test: additional integration tests for vpc (#335) ## 📝 Description - Extending test coverage for VPC ## ✔️ How to Test 1. Setup API token for alpha/beta environment and export it LINODE_TOKEN=mytoken 2. get cacert.pem (e.g. wget https://certurl.com/cacert.pem) 3. make slight modification to `def get_client()` in conftest.py e.g. `client = LinodeClient(token, base_url='https://api.dev.linode.com/v4beta', ca_path='/Users/ykim/linode/ykim/linode_api4-python/cacert.pem')` 4. run test `pytest test/integration/models/test_vpc.py` ## 📷 Preview **If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.** --------- Co-authored-by: Zhiwei Liang <[email protected]> Co-authored-by: Zhiwei Liang <[email protected]> * Add `vpc_nat_1_1` to IPAddress (#342) ## 📝 Description This change is adding `vpc_nat_1_1` to the IPAddress for VPC. If a public IPv4 address is NAT 1:1 mapped to a private VPC IP, this field is returned VPC IP together with the VPC and subnet ids. Also trying to merge two commits from dev to proj/vpc to update the feature branch. The actual change is focusing on 3206ab8. ## ✔️ How to Test Build unit test to make sure that we can retrieve this field from IPAddress object: `tox` --------- Co-authored-by: Zhiwei Liang <[email protected]> * implementation * fixing tests * json_object * Support list deserialise in `JSONObject` * cleaning up code * make format * Replace `get_client` with `test_linode_client` (#346) * fix: Handle `null` values in `JSONObject` fields (#344) ## 📝 Description **What does this PR do and why is this change necessary?** Handle null values for `JSONObject` fields ## ✔️ How to Test **What are the steps to reproduce the issue or verify the changes?** `pytest test/integration/models/test_networking.py` --------- Co-authored-by: Lena Garber <[email protected]> Co-authored-by: Lena Garber <[email protected]> Co-authored-by: Youjung Kim <[email protected]> Co-authored-by: Ye Chen <[email protected]> Co-authored-by: Ania Misiorek <[email protected]> Co-authored-by: Ania Misiorek <[email protected]> Co-authored-by: Jacob Riddle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Test fixture
get_clienthas been changed totest_linode_clientin dev branch. This is to change it for VPC tests.✔️ How to Test
pytest test/integration/models/test_vpc.pyGHA run: https://github.com/linode/linode_api4-python/actions/runs/6789530531