Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Linode Cloud Firewall for integration tests #408

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented May 27, 2024

📝 Description

This PR implements Linode Cloud Firewall for integration tests to enhance security.

  • Default Inbound policy: DROP
  • Default Outbound policy: ACCEPT
  • Inbound rule: inbound rule with public ip on port 22

Note: GHA does not support ipv6 so only ipv4 will get added in firewall during GHA execution. However, ipv6 will get added automatically if ipv6 address and route exist

✔️ How to Test

make test-int

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner May 27, 2024 18:12
@ykim-akamai ykim-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team May 27, 2024 18:12
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works locally, just need to address @zliang-akamai feedback.

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jriddle-linode jriddle-linode added the testing for updates to the testing suite in the changelog. label Jun 12, 2024
@ykim-akamai ykim-akamai merged commit 7ccc16c into linode:dev Jun 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants