Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObjectStorageACL a StrEnum #420

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Jun 15, 2024

📝 Description

The StrEnum implementation was copied from #413, authored by @lgarber-akamai

This is to make ObjectStorageACL to be a StrEnum.

✔️ How to Test

make testunit

from linode_api4.objects import ObjectStorageACL

client = LinodeClient(os.getenv("LINODE_TOKEN"))

bucket1 = client.object_storage.bucket_create(
    "us-mia-1",
    "test-python-sdk-bucket",
    ObjectStorageACL.PRIVATE,
)

print(bucket1._raw_json)
bucket1.delete()

@zliang-akamai zliang-akamai requested a review from a team as a code owner June 15, 2024 05:07
@zliang-akamai zliang-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team June 15, 2024 05:07
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@zliang-akamai zliang-akamai merged commit 78574da into linode:dev Jun 18, 2024
7 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/obj-acl-enum branch June 18, 2024 16:11
@zliang-akamai zliang-akamai added the improvement for improvements in existing functionality in the changelog. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants