-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OBJ Group and Objects for MultiCluster Object Storage API Changes #426
Update OBJ Group and Objects for MultiCluster Object Storage API Changes #426
Conversation
…`DeprecationWarning`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing on my end and I haven't run into any more issues when testing against this from Ansible. Excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works locally, nice work!
id_attribute = "label" | ||
|
||
properties = { | ||
"cluster": Property(identifier=True), | ||
"region": Property(identifier=True), | ||
"cluster": Property(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a deprecated note to the cluster
property as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the head up! I think there isn't a clear way to mark it as deprecated in Python since the property is in a dict... Let me think about it maybe we can modify Property
class to accept a deprecation flag. I can do that in a future PR, I think.
* Add warnings to deprecated OBJ API usage (#410) * add deprecated * add dependency * fix deprecated * Update OBJ Group and Objects for MultiCluster Object Storage API Changes (#426) --------- Co-authored-by: Ye Chen <[email protected]>
📝 Description
This is to modify
ObjectStorageGroup
and object storage related SDK objects to adapt to the MultiCluster Object Storage API changes.✔️ How to Test
Automated Testing
Manual Testing