Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linodes and OBJ Integration Tests Improvements #434

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Linodes and OBJ Integration Tests Improvements #434

merged 3 commits into from
Jul 10, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Jul 10, 2024 •
edited
Loading

📝 Description

To increase test code readability and reliability.

✔️ How to Test

pytest test/integration/models/linode/test_linode.py -k test_save_linode_force
pytest test/integration/models/linode/test_linode.py -k test_save_linode_noforce
pytest test/integration/models/object_storage/test_obj.py

Full integration tests suite run: https://github.com/linode/linode_api4-python/actions/runs/9869998519 (may contains other unfixed failures)

@zliang-akamai zliang-akamai requested a review from a team as a code owner July 10, 2024 06:45
@zliang-akamai zliang-akamai requested review from jriddle-linode, lgarber-akamai and ykim-akamai and removed request for a team July 10, 2024 06:45
@ezilber-akamai ezilber-akamai self-requested a review July 10, 2024 13:29
lgarber-akamai
lgarber-akamai approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and all tests are passing on my end, nice work!

ezilber-akamai
ezilber-akamai approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing locally!

@lgarber-akamai lgarber-akamai merged commit 639588d into linode:dev Jul 10, 2024
7 checks passed
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@jriddle-linode jriddle-linode Awaiting requested review from jriddle-linode jriddle-linode is a code owner automatically assigned from linode/dx

@ykim-akamai ykim-akamai Awaiting requested review from ykim-akamai

Assignees
No one assigned
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zliang-akamai @lgarber-akamai @ezilber-akamai