Project: Image Services Gen2

[yec-akamai]

📝 Description

Project Image Gen2 LA

make testint TEST_SUITE=linode_client

make testint TEST_SUITE=image

[ezilber-akamai]

I got an error when running make testint TEST_SUITE=linode_client locally. It doesn't seem to be related to the changes though. I tried in a different branch and saw the same error.

_______________________________________________________________________________________ test_get_account_settings _______________________________________________________________________________________

test_linode_client = <linode_api4.linode_client.LinodeClient object at 0x104a0f100>

    def test_get_account_settings(test_linode_client):
        client = test_linode_client
        account_settings = client.account.settings()
    
        assert account_settings._populated == True
>       assert re.search(
            "'network_helper':True|False", str(account_settings._raw_json)
        )
E       assert None
E        +  where None = <function search at 0x102ac54c0>("'network_helper':True|False", "{'managed': True, 'network_helper': True, 'longview_subscription': 'longview-100', 'backups_enabled': True, 'object_storage': 'active'}")
E        +    where <function search at 0x102ac54c0> = re.search
E        +    and   "{'managed': True, 'network_helper': True, 'longview_subscription': 'longview-100', 'backups_enabled': True, 'object_storage': 'active'}" = str({'backups_enabled': True, 'longview_subscription': 'longview-100', 'managed': True, 'network_helper': True, ...})
E        +      where {'backups_enabled': True, 'longview_subscription': 'longview-100', 'managed': True, 'network_helper': True, ...} = AccountSettings: True._raw_json

[ezilber-akamai]

I'm also running into a 404 when running make testint TEST_SUITE=image but this is likely because the test isn't being run in the correct region. Is there some additional setup I need to do to run the test against the right region?

[yec-akamai]

I'm also running into a 404 when running make testint TEST_SUITE=image but this is likely because the test isn't being run in the correct region. Is there some additional setup I need to do to run the test against the right region?

Interesting, I've hardcoded the region to be us-east and it should work. Do you have the customer tag we mentioned in the thread?

[lgarber-akamai]

@ezilber-akamai For the account settings test, it looks like the regex is looking for 'network_helper':True or just False instead of 'network_helper': True or 'network_helper': False. I'm guessing this is causing a failure on your end since your account doesn't seem to have any disabled settings.

I think the corrected pattern would look like this:

'network_helper':\s*(True|False)

If we don't want to include that fix in this PR since it's out of scope, it might be ticket-worthy 🙂

[yec-akamai]

If we don't want to include that fix in this PR since it's out of sc

Good point! I included this fix in the PR. Also I changed a bit the get random region function to make sure we only get core site for testing. Some of the functions are not available in non-core sites.

[ezilber-akamai]

Tests passing locally. Nice work!

[ykim-1]

LGTM tests pass locally