Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: Support pricing for LKE, Volume, NodeBalancer and Network Transfer #454

Merged
merged 2 commits into from
Sep 11, 2024
Merged

new: Support pricing for LKE, Volume, NodeBalancer and Network Transfer #454

merged 2 commits into from
Sep 11, 2024

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Add support for the following pricing endpoints:

✔️ How to Test

Unit test:

make testunit

Integration tests:

make testint TEST_COMMAND="models/volume"
make testint TEST_COMMAND="models/networking"
make testint TEST_COMMAND="models/lke"
make testint TEST_COMMAND="models/nodebalancer"

@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Sep 5, 2024
@yec-akamai yec-akamai requested a review from a team as a code owner September 5, 2024 20:17
@yec-akamai yec-akamai requested review from ykim-akamai and ezilber-akamai and removed request for a team September 5, 2024 20:17
ezilber-akamai
ezilber-akamai approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passing locally! Are the TODOs for API Documentation there because there aren't tech docs pages for these endpoints yet?

@yec-akamai
Copy link
Contributor Author

Test passing locally! Are the TODOs for API Documentation there because there aren't tech docs pages for these endpoints yet?

Yep I didn't find these new endpoints in the tech doc

ykim-akamai
ykim-akamai approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, slightly added more details to integration tests. Nice work!

@yec-akamai
Copy link
Contributor Author

LGTM, slightly added more details to integration tests. Nice work!

Thank you for adding the integration tests! They looks perfect and work well on my end 🎉

@yec-akamai yec-akamai merged commit 1d155a9 into linode:dev Sep 11, 2024
7 checks passed
@yec-akamai yec-akamai deleted the TPT-3122/support-pricing branch September 11, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@ykim-akamai ykim-akamai ykim-akamai approved these changes

Assignees
No one assigned
Labels
new-feature for new features in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yec-akamai @ykim-akamai @ezilber-akamai