Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Address pytest warnings; remove duplicate test helper #463

Merged

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

  • Remove pytest warnings on tests that are marked with pytest.ini file.
    e.g.
test/integration/models/profile/test_profile.py:37
  /home/runner/work/linode_api4-python/linode_api4-python/test/integration/models/profile/test_profile.py:37: PytestUnknownMarkWarning: Unknown pytest.mark.flaky - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.flaky(reruns=3, reruns_delay=2)
  • Remove duplicate test helper

  • Add pytest-rerunfailures in pyproject.toml to allow dev-install to pick up the library during test runs

✔️ How to Test

make testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner September 26, 2024 19:45
@ykim-akamai ykim-akamai requested review from zliang-akamai and yec-akamai and removed request for a team September 26, 2024 19:45
pytest.ini Outdated Show resolved Hide resolved
@zliang-akamai zliang-akamai self-requested a review October 1, 2024 08:20
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests passed locally!

@ykim-akamai ykim-akamai merged commit 9d63e07 into linode:dev Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants