-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8648] – Migrate several components to ui
package prior to migrating Paper
#11159
refactor: [M3-8648] – Migrate several components to ui
package prior to migrating Paper
#11159
Conversation
…el components to linode/ui package and update imports/exports accordingly
…nputAdornment`, and `InputLabel` from `manager` to `ui` package
I think I set the wrong precedent with For example, we could create a directory |
We have a mix of both approaches in |
Sounds good, I'd be interested to hear what others think though. I believe we are migrating unit tests though, for components that have them. |
Just chiming in to say that I like directories for components and their related files a lot. The loose files kind of stress me out. 😅 We actually recommend the dirs as a best practice in our docs: https://linode.github.io/manager/development-guide/01-repository-structure.html#where-to-go-for-common-tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Components working as expected. Approved pending decision on whether to make component folders.
Good catch that it's in the docs, I think we should abide by that then. |
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Dajahi! 🎉
✅ checked throughout CM, didn't see any page crashes/things looked the same
Cloud Manager E2E Run #6749
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6749
|
Run duration | 25m 43s |
Commit |
7a17a78f90: refactor: [M3-8648] – Migrate several components to `ui` package prior to migrat...
|
Committer | Dajahi Wiley |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
445
|
View all changes introduced in this branch ↗︎ |
Description 📝
Migrate the following components from
manager
toui
:FormControl
FormHelperText
Input
InputAdornment
InputLabel
This PR is the result of a cascade of dependencies when I initially tried migrating
Paper
, which importsFormHelperText
. I wanted to avoid a giant 200+ file PR so this PR sets the groundwork for a follow-up PR focused on migratingPaper
by handling the cascade of dependencies and cleaning up TS errors.Target release date 🗓️
11/12/24
How to test 🧪
Verification steps
As an Author I have considered 🤔