fix: [M3-8929] - Unexpected gradient on Linode Detail with VPC interface #11289
Conversation
abailly-akamai
requested review from
carrillo-erik,
coliu-akamai and
mjac0bs
and removed request for
a team
| <StyledGradientDiv> | ||
| <CopyTooltip | ||
| copyableText | ||
| text={configInterfaceWithVPC.ipv4.vpc} | ||
| /> | ||
| </StyledGradientDiv> | ||
| <StyledCopyTooltip text={configInterfaceWithVPC.ipv4.vpc} /> | ||
| {configInterfaceWithVPC.ipv4.vpc} | ||
| <Box sx={{ ml: 1, position: 'relative', top: 1 }}> | ||
| <StyledCopyTooltip text={configInterfaceWithVPC.ipv4.vpc} /> | ||
| </Box> |
There was a problem hiding this comment.
For consistency with the other copyable tooltips, we should make both the text and the icon copyable. Technically the gradient too but it's too slight to notice and we should probably remove it in the other places as well. No idea why the gradient broke here and not prior.
There was a problem hiding this comment.
For consistency with the other copyable tooltips, we should make both the text and the icon copyable.
This is a good point - agreed.
There was a problem hiding this comment.
fixed
No idea why the gradient broke here and not prior.
It is most likely because the gradient is absolutely positioned, and if there is no immediate parent container with a relative position it will bubble up to to the next relative one, which can be any.
Long story short, there's no need for the gradient on this particular instance
There was a problem hiding this comment.
All good now.
Users can technically still click the action menu with the gradient bug, it just requires extreme precision. Thanks for the quick fix, @abailly-akamai!
abailly-akamai
force-pushed
the
M3-8929
branch
from
950c22c
to
ff321d5
Compare
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/stackscripts/update-stackscripts.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 23s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
452
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/stackscripts/update-stackscripts.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Update stackscripts > updates a StackScript |
Screenshots
Video
|
|
cypress/e2e/core/linodes/linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > Mocked > Creates a new config using non-recommended settings and confirm the informational notices |
Screenshots
Video
|
|
Description 📝
This PR fixes a wrong implementation of the Linode Detail VPC IP copy UI, introduced by #11172
It is not only a bad visual defect, but also prevents the ability to click on the action menu
Changes 🔄
<StyledGradientDiv>Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author, I have considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
I have read and considered all applicable items listed above.
As an Author, before moving this PR from Draft to Open, I confirmed ✅