Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce metrics bloat + bump to terraform v2.22.0 #37

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

tchinmai7
Copy link
Collaborator

Description of your changes

  1. Reduce metrics bloat - by collecting api call counters at service level instead of per resource
  2. bump to terraform provider-linode v2.22.0
  3. Includes unreleased changes to terraform-provider-linode and linodego.
  4. Count API responses instead of requests

These metrics show up post these changes

# HELP linode_api_responses_last_5m Number of Linode API responses by return code and first 5 digits of the token
# TYPE linode_api_responses_last_5m counter
linode_api_responses_last_5m{account="21a97",code="200",method="GET",url="keys"} 1
# HELP linode_api_responses_total Number of Linode API responses by return code and first 5 digits of the token
# TYPE linode_api_responses_total counter
linode_api_responses_total{account="21a97",code="200",method="GET",url="keys"} 1

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@tchinmai7 tchinmai7 merged commit e46e17c into main Jun 10, 2024
6 checks passed
@tchinmai7 tchinmai7 deleted the metrics-refinement branch June 11, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants