Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placement group resources + bump terraform v2.23.0 #39

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

sammysclub
Copy link
Collaborator

Description of your changes

  • Adds support for PlacementGroup, PlacementGroupAssignments
  • (Also adds support for AccountSettings - missing before)
  • Bumps terraform provider linode version to v2.23.0
  • Adds to dev documentation for adding a new resource

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Ran make local-deploy and applied the placementgroupassignment.yaml manifest that was generated in the examples. (NOTE: needed to change the region to us-mia before applying, because placement groups are not supported in us-east.) Confirmed in Cloud Manager that the placement group was created, and that the linode instance was assigned to the group.

Copy link
Collaborator

@tchinmai7 tchinmai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@tchinmai7 tchinmai7 merged commit a37facb into linode:main Jun 25, 2024
6 checks passed
@sammysclub sammysclub deleted the add-placement-group branch June 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants