PCR documentation usage changes for coreboot 4.8.1 and newer versions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation changes linked to PCR usage in coreboot 4.8.1 and newer versions, to be applied at the same time as linuxboot/heads#793 is merged. Linked to VBOOT+Measured boot/Measured boot changes applied directly in coreboot so that we have a common base prior of going linuxboot/heads#709 and linuxboot/heads#721 @PatrickRudolph comments welcome
|
is the comment re: MRC meant to imply that we should measure the MRC blob / FSP-M separately from romstage? |
|
@MrChromebox as I understood, coreboot VBOOT+measuredboot/measuredboot will measure it all under PCR2. @osresearch intention was to seperate them initially. Coreboot merges them all in. I would just remove that comment. @MrChromebox opinion? |
|
+1 on removing the comment |
Removed comment about MRC needing to be measured into different PCR since coreboot is merging them all under PCR2 in newer VBOOT+measured boot/measuredboot Ref:https://doc.coreboot.org/security/vboot/measured_boot.html
MrChromebox
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation changes linked to PCR usage in coreboot 4.8.1 and newer versions, to be applied at the same time as linuxboot/heads#793 is merged.
Linked to VBOOT+Measured boot/Measured boot changes applied directly in coreboot so that we have a common base prior of going linuxboot/heads#709 and linuxboot/heads#721
@PatrickRudolph comments welcome