Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

novacustom_nv4x_adl -> novacustom-nv4x_adl consistent NovaCustom board naming scheme from now on #1899

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Jan 24, 2025

To confirm:

user@heads-tests-deb12-nix:~/heads$ grep -Rni mainboard config/coreboot-novacustom-nv4x_adl.config 
55:# Mainboard
114:CONFIG_MAINBOARD_FAMILY="Not Applicable"
115:CONFIG_MAINBOARD_PART_NUMBER="nv40pz"
116:CONFIG_MAINBOARD_VERSION="v2.1"
117:CONFIG_MAINBOARD_DIR="clevo/adl-p"
122:CONFIG_MAINBOARD_VENDOR="Notebook"
136:CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="Notebook"
137:CONFIG_INTEL_GMA_VBT_FILE="src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/data.vbt"
140:CONFIG_CMOS_DEFAULT_FILE="src/mainboard/$(MAINBOARDDIR)/cmos.default"
141:CONFIG_CMOS_LAYOUT_FILE="src/mainboard/$(MAINBOARDDIR)/cmos.layout"
145:CONFIG_MAINBOARD_SMBIOS_PRODUCT_NAME="NV4xPZ"
222:CONFIG_MAINBOARD_POWER_FAILURE_STATE=0
223:# end of Mainboard
724:CONFIG_MAINBOARD_HAS_TPM2=y
815:CONFIG_MAINBOARD_SERIAL_NUMBER="123456789"

and

user@heads-tests-deb12-nix:~/heads$ grep -Rni bios config/coreboot-novacustom-nv4x_adl.config 
69:# CONFIG_VENDOR_BIOSTAR is not set
135:# CONFIG_VGA_BIOS is not set
136:CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="Notebook"
145:CONFIG_MAINBOARD_SMBIOS_PRODUCT_NAME="NV4xPZ"
256:CONFIG_EXT_BIOS_WIN_BASE=0xf8000000
257:CONFIG_EXT_BIOS_WIN_SIZE=0x2000000
368:CONFIG_FAST_SPI_SUPPORTS_EXT_BIOS_WINDOW=y
532:CONFIG_BIOS_VENDOR="3mdeb"
575:# CONFIG_DUMP_SMBIOS_TYPE17 is not set
814:CONFIG_GENERATE_SMBIOS_TABLES=y
828:# CONFIG_PAYLOAD_SEABIOS is not set
852:# CONFIG_SEABIOS_SECONDARY_PAYLOAD is not set
user@heads-tests-deb12-nix:~/heads$ 

Amongst other string validation if necessary (futureproofing fwupd/DTS/internal EC automatic upgrade etc and other things i'm not thinking of/aware of).

@macpijan please do review approving this pr for merge, assigning to you.

…d naming scheme from now on

Signed-off-by: Thierry Laurion <[email protected]>
@tlaurion
Copy link
Collaborator Author

@macpijan ping (this should then be release commit)

@tlaurion tlaurion merged commit 89a9c1b into linuxboot:master Jan 30, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants