Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: systemd hardening #120

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

zsien
Copy link
Member

@zsien zsien commented Jun 24, 2024

@zsien zsien requested a review from a team June 24, 2024 06:39
@zsien zsien force-pushed the zs/systemdhardening branch 8 times, most recently from 759a00f to f3f8916 Compare June 25, 2024 09:54
BLumia
BLumia previously approved these changes Jun 26, 2024
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 2, 2024

TAG Bot

New tag: 6.0.12
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #119

@zsien zsien force-pushed the zs/systemdhardening branch 2 times, most recently from c822922 to 0708858 Compare September 2, 2024 06:34
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • debian/dde-api.sysusers文件中,用户deepin-api-device的权限设置可能过于宽泛,建议限制更详细的策略。
  • deepin-api-device服务的ExecStartExecStop命令可能需要更详细的错误处理和日志记录。
  • deepin-api-device服务的ProtectSystem策略设置为full,这可能对系统稳定性有较大影响,建议根据实际需求调整。
  • deepin-api-device服务的ReadOnlyPaths设置为/var/lib/deepin-sound-player,这可能导致服务无法正确访问该路径,建议检查路径是否正确或服务是否有必要的权限。
  • deepin-api-device服务的BindReadOnlyPaths设置为-/tmp/deepin-shutdown-sound.json,这可能需要临时文件或目录的额外处理,以确保服务的稳定性。

是否建议立即修改:

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • debian/dde-api.postinstdebian/dde-api.postrm文件中,建议添加错误处理逻辑以处理可能出现的错误。
  • debian/rules文件中,新增的override_dh_auto_installoverride_dh_strip规则可能会影响依赖关系和构建流程,需要确保这些更改不会引入问题。
  • misc/systemd/system/deepin-api-device.service文件中,新增的SystemdService属性dbus-org.deepin.dde.Device1.service可能会导致服务名称冲突,需要检查是否有其他服务使用相同的名称。
  • misc/systemd/system/deepin-locale-helper.servicemisc/systemd/system/deepin-login-sound.service中,移除了ProtectHomePrivateDevices策略,需要确保这些更改不会导致安全问题。
  • misc/systemd/system/deepin-shutdown-sound.service中,新增了ReadOnlyPathsBindReadOnlyPaths属性,需要确保这些更改不会影响系统稳定性。

是否建议立即修改:

@zsien zsien requested review from a team and BLumia September 2, 2024 09:02
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 26, 2024

TAG Bot

New tag: 6.0.13
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #122

fly602
fly602 previously approved these changes Oct 18, 2024
@fly602 fly602 merged commit bac9608 into linuxdeepin:master Oct 18, 2024
16 of 17 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants