Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cross-thread parenting failure #949

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

asterwyx
Copy link
Contributor

@asterwyx asterwyx commented Jan 8, 2024

Cannot create a child in another thread. Do not use object tree, use QScopedPointer to manage life scope.

Log: fix cross-thread parenting failure

@asterwyx asterwyx requested a review from tsic404 January 8, 2024 07:31
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asterwyx
Copy link
Contributor Author

asterwyx commented Jan 8, 2024

/retest

@tsic404
Copy link
Contributor

tsic404 commented Jan 9, 2024

/check obs

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 9, 2024

Deepin Obs Bot
Deepin redeliveried failed, need update or recreate pull request!!!

@tsic404
Copy link
Contributor

tsic404 commented Jan 9, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 9, 2024

This pr cannot be merged! (status: behind)

Cannot create a child in another thread. Do not use object tree, use
QScopedPointer to manage life scope.

Log: fix cross-thread parenting failure
@tsic404
Copy link
Contributor

tsic404 commented Jan 9, 2024

/merge

@deepin-bot deepin-bot bot merged commit 12d346a into linuxdeepin:master Jan 9, 2024
18 checks passed
@asterwyx asterwyx deleted the patch-1 branch January 16, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants