Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [server] exit server when PrepareForShutdown emitted. #1942

Merged
merged 1 commit into from
May 7, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Apr 16, 2024

to make server exit before udisksd when shutdown/reboot.

Log: as title.

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 16, 2024

TAG Bot

New tag: 6.0.47
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1945

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 18, 2024

TAG Bot

New tag: 6.0.48
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1949

@itsXuSt itsXuSt marked this pull request as ready for review April 24, 2024 02:26
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 30, 2024

TAG Bot

New tag: 6.0.49
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1967

@itsXuSt itsXuSt force-pushed the master branch 2 times, most recently from 92a7dad to ec3fe31 Compare May 7, 2024 02:01
to make server exit before udisksd when shutdown/reboot.

Log: as title.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Core::start函数中增加了对QDBusConnection::systemBus().connect的调用,但没有检查连接是否成功,可能会导致未处理的连接失败情况。
  • Core::exitOnShutdown函数中直接使用qApp->exit(0)进行退出,但没有释放资源或执行清理工作。
  • Core::exitOnShutdown函数的参数名称为shutdown,但实际传入的是一个布尔值,可能会引起误解。建议使用更明确的参数名,如isShutdown

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented May 7, 2024

/merge

@deepin-bot deepin-bot bot merged commit e7c67ac into linuxdeepin:master May 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants