Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [342337/titlebar] show/copy network url #1959

Merged
merged 1 commit into from
May 7, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Apr 25, 2024

if path is smb/cifs/ftp/sftp.

Log: as title.

Task: https://pms.uniontech.com/task-view-342337.html

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 30, 2024

TAG Bot

New tag: 6.0.49
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1967

@itsXuSt itsXuSt force-pushed the smb_addr branch 2 times, most recently from 8609598 to 30c5977 Compare May 6, 2024 06:03
@itsXuSt itsXuSt marked this pull request as ready for review May 7, 2024 01:58
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SmbBrowserEventReceiver::getOriginalUri函数中,使用了QRegularExpression来匹配路径,但没有考虑到跨平台兼容性问题,应该使用QDirQFileInfo来处理路径。
  • SmbBrowserEventReceiver::getOriginalUri函数中处理GVFS路径时,直接使用了SyncFileInfo对象来获取URL,这可能不是跨平台的,应该使用QFileQFileInfo来处理。
  • SmbBrowserEventReceiver::hookTitleBarAddrHandle函数中,对url的校验是多余的,因为dpfHookSequence->run函数已经保证了url是一个有效的QUrl对象。
  • SmbBrowserEventReceiver类中的private成员函数getOriginalUri应该标记为public,以便在类的外部被调用。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented May 7, 2024

/merge

@deepin-bot deepin-bot bot merged commit 25a9f6f into linuxdeepin:master May 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants