feat: Allow opening duplicate clicked folders within the same process #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TAG Bot New tag: 6.0.49 |
liyigang1
changed the title
liyigang1
force-pushed
the
fix-2
branch
3 times, most recently
from
7a16f8a
to
6be5f79
Compare
liyigang1
force-pushed
the
fix-2
branch
2 times, most recently
from
d41751a
to
b758af5
Compare
Johnson-zs
requested changes
May 7, 2024
| @@ -32,7 +32,7 @@ class Application : public QObject | |||
| kUrlOfNewTab, // default path to new tabs | |||
| kThemeName, | |||
| kFileAndDirMixedSort, // Mixed sorting of ordinary files and directories | |||
| kListItemExpandable // Item expandable as tree in FileView with list view mode | |||
| kListItemExpandable, // Item expandable as tree in FileView with list view mode | |||
| @@ -199,6 +199,17 @@ | |||
| "description[zh_CN]": "日志规则", | |||
| "permissions": "readwrite", | |||
| "visibility": "public" | |||
| }, | |||
| "dfm.open.folder.in.a.separate.process": { | |||
There was a problem hiding this comment.
写到org.deepin.dde.file-manager.view.json去更合适
src/plugins/filemanager/core/dfmplugin-workspace/events/workspaceeventcaller.h
Show resolved
Hide resolved
liyigang1
force-pushed
the
fix-2
branch
3 times, most recently
from
544f792
to
8a416bc
Compare
Johnson-zs
reviewed
May 8, 2024
| kOpenfolderwindowsinaseparateprocess, false).toBool(); | ||
|
|
||
| auto target = item->targetUrl(); | ||
| if (flag && FileManagerWindowsManager::instance().containsCurrentUrl(target, window())) { |
There was a problem hiding this comment.
如果一个窗口有多个tab，其中一个tab的url和当前tab的url一样，会什么效果
There was a problem hiding this comment.
需求说的不管tab页，只需要验证当前的显示的url
Allow opening duplicate clicked folders within the same process Log: Allow opening duplicate clicked folders within the same process Task: https://pms.uniontech.com/task-view-341709.html
deepin pr auto review |
Johnson-zs
approved these changes
May 9, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs, liyigang1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow opening duplicate clicked folders within the same process
Log: Allow opening duplicate clicked folders within the same process
Task: https://pms.uniontech.com/task-view-341709.html