Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [computer] avoid updating device size #1978

Merged
merged 3 commits into from
May 9, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented May 9, 2024

if QStorageInfo returns a negative value, ignore this changes, avoid
updating size of device in computer.

Log: as titel.

Bug: https://pms.uniontech.com/bug-view-254235.html

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 9, 2024

TAG Bot

New tag: 6.0.50
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1970

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • DeviceWatcherPrivate::queryUsageOfItem函数中,修改了条件判断逻辑,旧的实现如果old不等于newStorage,就会触发查询,而修改后的代码只有在newStorage有效时才触发查询,这是一个合理的逻辑改动。
  • DialogManager::showErrorDialogWhenOperateDeviceFailed函数中,增加了对错误代码的检查,确保只有特定的错误码才会触发消息显示,这是一个security feature。
  • CifsMountHelper构造函数中,添加了空格使得代码更加清晰,这是一个style的改动。
  • convertArgs函数中,对opts参数的检查逻辑可能需要更新,但是修改后的代码似乎尝试将wait_reconnect_timeout的值设置为1,这可能是一个逻辑错误,需要确认新的kTryWaitReconn参数的逻辑和预期行为。

是否建议立即修改:

  • 需要确认kTryWaitReconn参数的逻辑和预期行为,确保错误处理逻辑的正确性。
  • 需要检查CifsMountHelperPrivate构造函数的初始化列表是否需要添加额外的初始化代码,以避免潜在的初始化错误。
  • 建议添加单元测试来验证convertArgs函数的行为,特别是在处理kTryWaitReconn参数时。
  • 建议恢复或增加注释来解释kTryWaitReconn参数的逻辑和期望的行为,以便其他开发者理解。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented May 9, 2024

/merge

@deepin-bot deepin-bot bot merged commit 04d33a8 into linuxdeepin:master May 9, 2024
17 checks passed
@max-lvs
Copy link
Contributor

max-lvs commented May 9, 2024

/topic cdapp-240509

@deepin-ci-robot
Copy link

Add topic: cdapp-240509 successed.

@max-lvs
Copy link
Contributor

max-lvs commented May 9, 2024

/integr-topic cdapp-240509

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants