Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化dfm-extension #1979

Merged
merged 2 commits into from
May 11, 2024
Merged

优化dfm-extension #1979

merged 2 commits into from
May 11, 2024

Conversation

Johnson-zs
Copy link
Contributor

  1. 主线程调用initialize
  2. 优化example

Some plugins construct GUI object in `initialize`, so must invoke `initialize` int the main thread.

Log: refactor extension
Remove version judgment

Log: Remove version judgment
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了多个信号和槽的连接,改为在工作线程中直接处理插件的初始化和加载。
  • 移除了doAppendExt函数中多个插件类型的判断和处理逻辑,改为在requestInitPlugin信号中处理。

是否建议立即修改:

Syntax and logical errors:

  • 无明显的语法或逻辑错误。

Code refactoring and quality:

  • 代码重构可能导致可读性和维护性问题,需要确保新的架构能够满足需求并且易于理解。

Performance optimization:

  • 由于移除了多个信号和槽的连接,并且改为在工作线程中直接处理,可能会对性能有轻微的影响,但这种影响应该会在软件的使用过程中逐渐消失,并且不会成为瓶颈。

Security vulnerabilities:

  • 没有涉及到安全性的改动。

Best practices:

  • 确保代码的修改遵循了项目的编码规范,包括命名约定、代码格式和代码结构等。
  • 添加必要的注释来解释新的工作线程和信号处理的逻辑,以便其他开发者理解。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 9, 2024

TAG Bot

New tag: 6.0.50
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1970

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit a853f1c into linuxdeepin:master May 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants