Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The shortcut file "bensound sunny. mp3" in the music directory cannot be moved to the trash #2022

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

liyigang1
Copy link
Contributor

Determine if there is an interface issue that supports the trash operation, and supplement the judgment. If it is a linked file and it is in the main directory, it can be deleted

Log: The shortcut file "bensound sunny. mp3" in the music directory cannot be moved to the recycle bin
Bug: https://pms.uniontech.com/bug-view-259171.html

…annot be moved to the trash

Determine if there is an interface issue that supports the trash operation, and supplement the judgment. If it is a linked file and it is in the main directory, it can be deleted

Log: The shortcut file "bensound sunny. mp3" in the music directory cannot be moved to the recycle bin
Bug: https://pms.uniontech.com/bug-view-259171.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • canTrash变量赋值时,应该检查sourceInfo是否为nullptr,以避免潜在的空指针解引用错误。
  • filesource.path().startsWith(StandardPaths::location(StandardPaths::StandardLocation::kHomePath))可能会导致性能问题,应该确认是否有必要对每个文件进行检查。
  • DialogManagerInstance->showDeleteFilesDialog(sources, true)可能会弹出对话框给用户,应该确保这种行为是符合用户预期的,并且不会引起用户混淆。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 640f700 into linuxdeepin:master Jun 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants