Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dragging files from the trash to a USB drive for undo can cause dde-file-manager to freeze #2023

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

liyigang1
Copy link
Contributor

Error in passing parameters during complete deletion

Log: Dragging files from the trash to a USB drive for undo can cause dde-file-manager to freeze
Bug: https://pms.uniontech.com/bug-view-259887.html

…dde-file-manager to freeze

Error in passing parameters during complete deletion

Log: Dragging files from the trash to a USB drive for undo can cause dde-file-manager to freeze
Bug: https://pms.uniontech.com/bug-view-259887.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • doMoveToTrash函数中,新增参数isInit未在函数定义中说明其用途和行为
  • handle变量在赋值后没有检查返回值,可能会导致未处理的初始化错误
  • DialogManagerInstance->showDeleteFilesDialog函数调用可能需要错误处理和用户确认的确认

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 8eb76d1 into linuxdeepin:master Jun 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants