Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: After enabling the long file name function, delete files to the trash. Right click on the attribute window and there is marked information that can be edited #2028

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

liyigang1
Copy link
Contributor

All trash files cannot be marked. Register the hook_cantag function and return a tag that is not allowed

Log: After enabling the long file name function, delete files to the trash. Right click on the attribute window and there is marked information that can be edited
Bug: https://pms.uniontech.com/bug-view-260621.html

…trash. Right click on the attribute window and there is marked information that can be edited

All trash files cannot be marked. Register the hook_cantag function and return a tag that is not allowed

Log:  After enabling the long file name function, delete files to the trash. Right click on the attribute window and there is marked information that can be edited
Bug: https://pms.uniontech.com/bug-view-260621.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Trash::followEvents函数中,searchPlugin变量被声明但未使用,应考虑移除或添加相关代码以使用该变量。
  • Trash::bindWindows函数中缺少对DPF_NAMESPACE::Listener实例的声明,可能导致编译错误。
  • TrashFileHelper::handleCanTag函数中,对canTag变量的赋值操作应该在条件判断之后进行,以避免在未赋值的情况下使用。
  • TrashFileHelper::handleCanTag函数中的if (canTag)检查是多余的,因为*canTag已经被初始化为false
  • TrashFileHelper::handleCanTag函数中的if (url.scheme() == scheme() || FileUtils::isTrashFile(url))检查可能存在逻辑错误,应该确认是否需要同时满足两个条件。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit f619e60 into linuxdeepin:master Jun 19, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants