Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When restoring files with long file names from trash, the prompt window icon and file size display error for replacing existing files #2031

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

liyigang1
Copy link
Contributor

Create a fileinfo using the scheme of trash, retrieve the restored original path, and recreate the fileinfo

Log: When restoring files with long file names from trash, the prompt window icon and file size display error for replacing existing files
Bug: https://pms.uniontech.com/bug-view-259587.html

… window icon and file size display error for replacing existing files

Create a fileinfo using the scheme of trash, retrieve the restored original path, and recreate the fileinfo

Log: When restoring files with long file names from trash, the prompt window icon and file size display error for replacing existing files
Bug: https://pms.uniontech.com/bug-view-259587.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FileOperateBaseWorker::trashInfo函数中,移除了不必要的空行,但没有修改其他代码,可能会影响代码的可读性。
  • DoRestoreTrashFilesWorker::doRestoreTrashFiles函数中,创建了一个新的DFileInfo对象fileInfo,但未释放或重置原始对象,可能会导致内存泄漏。
  • trashInfoUrl的构建方式可能会导致不必要的字符串拼接,建议使用QUrl::fromEncodedQUrl::fromPercentEncoded方法来构建URL。
  • fileInfo.reset(new DFileInfo(trashUrl));这行代码可能会覆盖原始的DFileInfo对象,需要确认这是否是预期的行为。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit f614642 into linuxdeepin:master Jun 19, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants