Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [desktop] when menu pops up, the input method can still be used #2032

Merged

Conversation

GongHeng2017
Copy link
Contributor

  1. When the wayland menu pops up, there is no focus on seizing, causing the input method to not disappear.
  2. In the Wayland mode, when the menu pops up, the input method is disabled

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-259639.html

…ill be used.

1. When the wayland menu pops up, there is no focus on seizing, causing the
input method to not disappear.
2. In the Wayland mode, when the menu pops up, the input method is disabled

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-259639.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CanvasView::contextMenuEvent函数中,setAttribute的调用顺序可能会导致WA_InputMethodEnabled的设置不正确。应该在设置属性之前保存当前的属性值,然后在设置新属性后恢复之前保存的属性值。
  • WindowUtils::isWayLand()函数的调用可能不是必要的,因为setAttribute的调用是在contextMenuEvent函数中进行的,而WindowUtils::isWayLand()函数是在startDrag函数中调用的。如果setAttribute的调用不会受到startDrag的影响,那么WindowUtils::isWayLand()的调用可能是多余的。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit b66ee5a into linuxdeepin:master Jun 24, 2024
57 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants