Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Search] The clear search dialog show multiple times. #2035

Merged

Conversation

GongHeng2017
Copy link
Contributor

Add the window id, let the parent window get the signal and clear the search history.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-259865.html

Add the window id, let the parent window get the signal
and clear the search history.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-259865.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Application::appAttributeTrigger函数中新增了一个参数winId,但未检查是否所有调用该函数的地方都已经更新以处理这个参数。
  • SettingDialog::createPushButton函数中连接槽函数时,直接使用了Application::appAttributeTrigger,但没有传递winId参数。
  • AddressBarPrivate::onClearSearchHistory函数增加了对窗口ID的检查,但只检查了传入的winId是否与当前窗口ID匹配,而没有检查是否与q指向的窗口ID匹配。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit aca59fb into linuxdeepin:master Jun 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants