Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: dde-file-manager crash" #2036

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Jun 21, 2024

Reverts #2003

Copy link

github-actions bot commented Jun 21, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@itsXuSt
Copy link
Contributor Author

itsXuSt commented Jun 21, 2024

recheck

@itsXuSt
Copy link
Contributor Author

itsXuSt commented Jun 21, 2024

/recheck

1 similar comment
@itsXuSt
Copy link
Contributor Author

itsXuSt commented Jun 21, 2024

/recheck

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented Jun 21, 2024

I have read the CLA Document and I hereby sign the CLA.

@itsXuSt itsXuSt closed this Jun 21, 2024
deepin-bot bot added a commit to linuxdeepin/cla that referenced this pull request Jun 21, 2024
@itsXuSt itsXuSt reopened this Jun 21, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了与QApplication的aboutToQuit信号的连接,需要确认这是否是有意为之。
  • 删除了watcher对象停止监视的代码,需要验证这是否会影响文件监视功能。
  • 移除了workerThread的quit和wait方法,这可能会影响到线程的优雅退出。

是否建议立即修改:

  • 是,需要确保移除aboutToQuit信号连接是有意为之,并且不会影响程序的预期行为。
  • 是,需要验证删除watcher停止监视代码是否会影响文件监视功能。
  • 是,需要确认移除workerThread的quit和wait方法是否会影响程序的线程管理。

@itsXuSt
Copy link
Contributor Author

itsXuSt commented Jun 21, 2024

/merge

@deepin-bot deepin-bot bot merged commit 30b5c8a into linuxdeepin:master Jun 21, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants