Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: dde-file-manager crash" #2037

Closed
wants to merge 1 commit into from
Closed

Conversation

Johnson-zs
Copy link
Contributor

Reverts #2003

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了与QApplication的aboutToQuit信号的连接,需要确认这是否是有意为之。
  • 删除了watcher对象停止监视的代码,需要验证这是否会影响文件监视功能。
  • 移除了workerThread的quit和wait方法,这可能会影响到线程的优雅退出。

是否建议立即修改:

  • 是,需要确保移除aboutToQuit信号连接是有意为之,并且不会影响程序的预期行为。
  • 是,需要验证删除watcher停止监视代码是否会影响文件监视功能。
  • 是,需要确认移除workerThread的quit和wait方法是否会影响程序的线程管理。

Copy link

github-actions bot commented Jun 21, 2024

CLA Assistant Lite bot:

如果你是以企业贡献者的身份进行提交,请联系我们签署企业贡献者许可协议
If you submit as corporate contributor, please contact us to sign our Corporate Contributor License Agreement

感谢您的提交,我们非常感谢。 像许多开源项目一样,在接受您的贡献之前,我们要求您签署我们的个人贡献者许可协议。 您只需发布与以下格式相同的评论即可签署个人贡献者许可协议
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Individual Contributor License Agreement before we can accept your contribution. You can sign the Individual Contributor License Agreement by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA.

You can retrigger this bot by commenting recheck in this Pull Request

@Johnson-zs Johnson-zs closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants