Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The screen recording file is stored in the "Video" directory, but clicking on "Open Folder" in the banner notification will redirect to the main directory #2041

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

liyigang1
Copy link
Contributor

The dde file manager script CD did not include ""

Log: The screen recording file is stored in the "Video" directory, but clicking on "Open Folder" in the banner notification will redirect to the main directory
Bug: https://pms.uniontech.com/bug-view-261441.html

…t clicking on "Open Folder" in the banner notification will redirect to the main directory

The dde file manager script CD did not include ""

Log: The screen recording file is stored in the "Video" directory, but clicking on "Open Folder" in the banner notification will redirect to the main directory
Bug: https://pms.uniontech.com/bug-view-261441.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在正则表达式中增加了对 "./" 和 "../" 的检查,以确保路径不会向上或向下进入当前目录。
  • 修改了 cd 命令的参数,使用双引号将路径括起来,以避免 shell 解析问题。

是否建议立即修改:

  • 否,这次提交的修改看起来是为了提高代码的健壮性,防止路径遍历攻击。这些修改是合理的,没有发现需要立即修改的关键问题。但是,建议进行全面的测试以确保这些修改不会引入新的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 9d4345d into linuxdeepin:master Jun 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants