Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix #2044

Merged
merged 2 commits into from
Jun 25, 2024
Merged

bug fix #2044

merged 2 commits into from
Jun 25, 2024

Conversation

Johnson-zs
Copy link
Contributor

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在OpticalEventReceiver::handleTabCloseable函数中，原函数名handleTabClosable更改为handleTabCloseable，需要确认这是否是预期的更改，以及是否有相应的代码更新和测试。
  • 在Optical::bindEvents函数中，dpfHookSequence->follow的回调函数列表被更新，需要检查是否有其他地方也使用了相同的回调函数列表，以避免潜在的重复调用和错误。

是否建议立即修改:

  • 是，需要确保函数名更改是正确的，并且不会影响其他部分的代码。同时，需要检查回调函数列表的更新是否正确，避免潜在的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit a0de5bf into linuxdeepin:master Jun 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsXuSt itsXuSt itsXuSt approved these changes

@max-lvs max-lvs max-lvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Johnson-zs @deepin-ci-robot @itsXuSt @max-lvs