Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to drag files to disc #2045

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

liyigang1
Copy link
Contributor

Determine if there is a drop error

Log: Unable to drag files to disc
Bug: https://pms.uniontech.com/bug-view-260801.html

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 25, 2024

This pr cannot be merged! (status: blocked)

src/dfm-base/utils/fileutils.cpp Outdated Show resolved Hide resolved
Determine if there is a drop error

Log: Unable to drag files to disc
Bug: https://pms.uniontech.com/bug-view-260801.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FileInfoPrivate::canDrop()函数中,新增的条件判断可能会导致逻辑改变,需要确认这是否是预期的行为。
  • DragDropHelper::dragMove()函数中,hoverFileInfo->canAttributes(CanableInfoType::kCanDrop)的调用可能存在笔误,应该是hoverFileInfo->canAttributes(CanableInfoType::kCanDrop)
  • MasteredMediaFileInfo::supportedOfAttributes()函数中,新增的条件判断可能会导致功能改变,需要验证这是否符合预期。

是否建议立即修改:

  • 是,需要确保逻辑更改是正确的,并且不会引入新的问题。同时,需要验证新增的条件判断是否符合预期的功能需求。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 05dc94f into linuxdeepin:master Jun 26, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants