Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Video wallpaper adaptation to wayland #2048

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: Video wallpaper adaptation to wayland #2048

merged 2 commits into from
Jun 26, 2024

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Jun 25, 2024

Video wallpaper adaptation to wayland

Bug: https://pms.uniontech.com/bug-view-261717.html
Log: Video wallpaper adaptation to wayland

Video wallpaper adaptation to wayland

Bug: https://pms.uniontech.com/bug-view-261717.html
Log: Video wallpaper adaptation to wayland
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, myk1343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的代码中,qputenvsetenv函数的使用可能会导致环境变量污染,建议使用更安全的设置方法。
  • WindowUtils::isWayLand()的调用可能需要错误处理,以防止在非 Wayland 环境下运行时出现问题。
  • QSurfaceFormat的设置应该根据实际需要进行,而不是在编译时定义。
  • 缺少对新增代码的注释说明,应该添加以提高代码的可读性和可维护性。

是否建议立即修改:

@myk1343
Copy link
Contributor Author

myk1343 commented Jun 26, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 26, 2024

This pr cannot be merged! (status: unstable)

@max-lvs max-lvs merged commit 88e8834 into linuxdeepin:master Jun 26, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants