Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Batch renaming, "Renaming" option, shortcut key Enter not effective #2049

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

liyigang1
Copy link
Contributor

Add the enter key to renameBar for processing

Log: Batch renaming, "Renaming" option, shortcut key Enter not effective
Bug: https://pms.uniontech.com/bug-view-260431.html

Add the enter key to renameBar for processing

Log: Batch renaming, "Renaming" option, shortcut key Enter not effective
Bug: https://pms.uniontech.com/bug-view-260431.html
…t in renaming failure

When the selected file is empty, cancel renamba

Log: When batch modifying file names, deselecting the file will result in renaming failure
Bug: https://pms.uniontech.com/bug-view-259905.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • RenameBar::setVisible方法中,直接调用parentWidget()->setFocus()可能会导致循环设置焦点,应避免在父窗口设置焦点时再次调用setVisible
  • RenameBar::keyPressEvent方法中,处理键盘事件时应考虑使用QObject::connect来确保槽函数的正确连接,而不是直接使用emit
  • RenameBar::keyPressEvent方法中,对Qt::Key_ReturnQt::Key_Enter的判断逻辑可能不正确,因为Qt::Key_Enter实际上对应于Qt::Key_Return的ASCII码值。
  • RenameBar::onSelectUrlChanged方法中,当urls.isEmpty()时,直接调用emit clickCancelButton()可能会导致槽函数的多次调用,应避免在信号连接处多次触发槽函数。
  • RenameBar::onSelectUrlChanged方法中,应确保d->renameBtnstd::get<0>(d->buttonsArea)在所有情况下都有正确的指针指向,以避免潜在的悬空指针问题。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit c6579d4 into linuxdeepin:master Jun 26, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants