Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use 1070(v20) interfaces of dde-dock #2053

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

FeiWang1119
Copy link
Contributor

use 1070(v20) interfaces of dde-dock in community version (v23)

Log:

@FeiWang1119 FeiWang1119 requested a review from tsic404 June 26, 2024 07:14
Copy link
Contributor

@Johnson-zs Johnson-zs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMPLIE_ON_V23 在其他地方也有很多适配,不能直接删除

@FeiWang1119 FeiWang1119 force-pushed the master branch 4 times, most recently from 8829092 to e9cfef8 Compare June 28, 2024 09:49
@@ -32,7 +32,7 @@ DiskMountPlugin::DiskMountPlugin(QObject *parent)
diskPluginItem(new DiskPluginItem)
{
loadTranslator();
diskPluginItem->setVisible(false);
diskPluginItem->setVisible(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么改这里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

插了U盘, 插件里面一直不显示.也没看到它在哪个地方显示

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

use 1070(v20) interfaces of dde-dock in community version (v23)

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • diskmountplugin.cpp中,diskPluginItem的可见性被硬编码为true,这可能不是预期的行为,应该使用setVisible(false)来保持原有的隐藏状态。
  • diskmountplugin.h中的宏定义使用了不同的语法,这可能会导致编译错误或不一致性。建议使用#ifdef#endif来定义宏,而不是使用||操作符。
  • diskpluginitem.cpp中的updateIcon函数使用了QString &&iconName来创建临时字符串,这是一个好的做法,因为它避免了内存泄漏的风险。

是否建议立即修改:

@FeiWang1119
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit b0125c3 into linuxdeepin:master Jul 2, 2024
23 checks passed
itsXuSt added a commit to itsXuSt/dde-file-manager that referenced this pull request Jul 5, 2024
itsXuSt added a commit to itsXuSt/dde-file-manager that referenced this pull request Jul 5, 2024
itsXuSt added a commit to itsXuSt/dde-file-manager that referenced this pull request Jul 5, 2024
deepin-bot bot pushed a commit that referenced this pull request Jul 5, 2024
Lighto-Ku pushed a commit to Lighto-Ku/dde-file-manager that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants