Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error in Destructuring and Exiting Iteration Thread #2055

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

liyigang1
Copy link
Contributor

Modify that only cached iteration threads bind this exit signal

Log: Error in Destructuring and Exiting Iteration Thread
Bug: https://pms.uniontech.com/bug-view-259807.html https://pms.uniontech.com/bug-view-259807.html

Modify that only cached iteration threads bind this exit signal

Log: Error in Destructuring and Exiting Iteration Thread
Bug: https://pms.uniontech.com/bug-view-259807.html https://pms.uniontech.com/bug-view-259807.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • RootInfo::~RootInfo()中,等待已终止的线程可能会导致死锁,因为stop()wait()之间没有同步。
  • clearTraversalThread函数中,isRefresh参数被错误地添加了一个不必要的布尔值,这可能会导致混淆。
  • ut_rootinfo.cpp测试文件中,clearTraversalThread函数的调用缺少了isRefresh参数,这可能会影响测试结果。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 53d7183 into linuxdeepin:master Jun 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants