Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [cpu info] Cpu info show error in some platform. #2062

Merged

Conversation

GongHeng2017
Copy link
Contributor

the cpu hz show max.

Log: add cpu info
Task: https://pms.uniontech.com/task-view-354581.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中存在重复的QDBusMessage调用和解析,可以考虑将其封装成函数以提高代码复用性和可读性。
  • 变量cpuMaxMhz的命名不够直观,建议使用更具描述性的名称,如cpuClockSpeed
  • 在处理processor字符串时,直接使用了contains("Hz"),但没有考虑到可能存在的其他格式化字符串,建议使用更严谨的检查方法。
  • 变量dHz的命名不够直观,建议使用更具描述性的名称,如cpuClockFrequency
  • 字符串"f"QString::number函数中的使用可能会导致格式问题,建议使用更明确的格式说明符。
  • 代码中没有处理QDBusMessage可能抛出的异常,建议添加异常处理逻辑。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 4a401ba into linuxdeepin:master Jul 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants