Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Video wallpaper adaptation to wayland egl #2070

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Jun 28, 2024

Video wallpaper adaptation to wayland egl

Bug: https://pms.uniontech.com/bug-view-261717.html
Log: Video wallpaper adaptation to wayland egl

Video wallpaper adaptation to wayland egl

Bug: https://pms.uniontech.com/bug-view-261717.html
Log: Video wallpaper adaptation to wayland egl
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • first_check_wayland_env 函数中使用了 QProcessEnvironment::systemEnvironment() 来获取环境变量,但没有处理可能未设置的环境变量的情况。
  • first_check_wayland_env 函数的命名不够明确,建议使用更具描述性的名称,如 isWaylandSessionTypeOrDisplaySet
  • first_check_wayland_env 函数中的条件判断使用了 Qt::CaseInsensitive,但没有考虑到环境变量值的大小写敏感性。
  • first_check_wayland_env 函数中的条件判断逻辑可能不够严谨,只检查了 XDG_SESSION_TYPEWAYLAND_DISPLAY 是否包含 "wayland"(不区分大小写),但没有检查是否为空或是否只包含空格。
  • main 函数中使用了 qputenv 进行环境变量设置,但没有检查 setenv 是否成功设置环境变量。
  • main 函数中使用了未定义的 PULSE_PROP_media.role 环境变量,需要确认其用途和兼容性。
  • #ifndef __x86_64__ 预处理器指令可能不是必要的,应评估是否有特定的平台相关代码。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, myk1343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 485a648 into linuxdeepin:master Jun 29, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants