Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [select-dialog] Double-click to unable to open the file #2071

Merged

Conversation

GongHeng2017
Copy link
Contributor

When there are two choice boxes, double-click the file cannot be opened.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-261287.html

When there are two choice boxes, double-click the file cannot be opened.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-261287.html
@GongHeng2017 GongHeng2017 force-pushed the 20240701-master-fixSelectDialog branch from 378850b to 5a654a4 Compare July 1, 2024 01:59
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FileDialog::FileDialog构造函数中移除了initEventsFilter()的调用,需要确认这是否是有意为之。
  • initEventsFilter()函数被移除,但相关的代码逻辑仍然存在于FileDialog.cpp中。需要检查是否有其他部分在调用initEventsFilter()
  • onAcceptButtonClicked()函数被添加到了FileDialog类中,但没有相应的文档注释说明其用途。
  • FileDialog::initEventsConnect()函数中的代码被移除,需要确认这是否会影响其他功能。

是否建议立即修改:

  • 是,需要确保移除initEventsFilter()initEventsConnect()函数调用是有意为之,并且不会影响程序的正常功能。同时,添加的onAcceptButtonClicked()函数应该有相应的文档注释,以便其他开发者理解其用途。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit a7f14d6 into linuxdeepin:master Jul 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants